Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BitmapFunction out of the playground #194

Closed
sdrave opened this issue Nov 27, 2015 · 3 comments
Closed

Move BitmapFunction out of the playground #194

sdrave opened this issue Nov 27, 2015 · 3 comments
Milestone

Comments

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 27, 2015

This should be an interesting Function for many users, so we should not hide it in the playground. Before moving, we should check again the implementation, though.

@sdrave sdrave added this to the 0.4 milestone Nov 27, 2015
@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 27, 2015

@andreasbuhr, according to this documentation, an image mode 'L' should imply 8 bit grayscale, so the additional check in __init__ would not be necessary. I can also reproduce locally that an 16bit grayscale image has mode 'I'.

What version of PIL have you been using? According to this, there is supposed to be a depth attribute on the Image object which, however, is missing in my PIL version. If I remember correctly, you did not have it either?

@andreasbuhr
Copy link
Contributor

@andreasbuhr andreasbuhr commented Dec 10, 2015

I reproduced the problem I had. Indeed, it's sufficient to check for 'L' mode. The image I had problems with reports an 'I' mode.

@sdrave
Copy link
Member Author

@sdrave sdrave commented Dec 10, 2015

Done in 5f426dd.

@sdrave sdrave closed this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants