/pymor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename reductors #224

Closed
sdrave opened this Issue Feb 19, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  0.4
2 participants
@sdrave @ftalbrecht
@sdrave
Member

sdrave commented Feb 19, 2016

@JuliaBru told me that pymor.reductors.linear.reduce_stationary_affine_linear and
pymor.reductors.stationary.reduce_stationary_coercive are not very intuitive names, and I agree. How should we name them (@ftalbrecht)?

@sdrave sdrave added this to the 0.4 milestone Feb 19, 2016

@sdrave

This comment has been minimized.

Sign in to view
Member

sdrave commented Feb 19, 2016

Maybe reduce_coercive and reduce_coercive_simple in pymor.reductors.coercive?
@ftalbrecht

This comment has been minimized.

Sign in to view
Member

ftalbrecht commented Feb 19, 2016

What you propose could do. I do not have a better name at the moment...
@sdrave

This comment has been minimized.

Sign in to view
Member

sdrave commented Feb 25, 2016

Done in 16a56cb.

@sdrave sdrave closed this Feb 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment