New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[algorithms.greedy] drop default for extension_algorithm #82

Closed
ftalbrecht opened this Issue Nov 13, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@ftalbrecht
Member

ftalbrecht commented Nov 13, 2014

I ran into a situation where I was stupid enough to not give any extension algorithm to the greedy algorithm (thus ending up with the default trivial_basis_extension) which led to hard-to-interpret results. We discussed that defaulting to gram_schmidt_basis_extension might also not be a good idead (since one often wants to specify the product). Thus I propose to drop the default and force the user to explicitely set the basis extension algorithm.

@ftalbrecht ftalbrecht added this to the 0.4 milestone Nov 13, 2014

@sdrave

This comment has been minimized.

Member

sdrave commented Apr 28, 2015

Done in 1dd4632.

@sdrave sdrave closed this Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment