Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append Operator to LinearAdvectionLaxFriedrichs, Concatenation and ComponentProjection #1046

Merged
merged 9 commits into from Aug 27, 2020
Merged

Append Operator to LinearAdvectionLaxFriedrichs, Concatenation and ComponentProjection #1046

merged 9 commits into from Aug 27, 2020

Conversation

pmli
Copy link
Member

@pmli pmli commented Aug 6, 2020

Closes #989.

@pmli pmli added the pr:change Change in existing functionality label Aug 6, 2020
@pmli pmli added this to the 2020.2 milestone Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited

Codecov Report

Merging #1046 into master will decrease coverage by 0.01%.
The diff coverage is 73.58%.

Impacted Files Coverage Δ
src/pymor/reductors/basic.py 77.77% <33.33%> (ø)
src/pymor/operators/ei.py 66.40% <50.00%> (ø)
src/pymor/operators/constructions.py 84.70% <52.94%> (-0.13%) ⬇️
src/pymor/discretizers/builtin/fv.py 66.92% <70.00%> (+0.06%) ⬆️
src/pymor/algorithms/image.py 80.00% <100.00%> (ø)
src/pymor/algorithms/preassemble.py 81.25% <100.00%> (ø)
src/pymor/algorithms/projection.py 78.85% <100.00%> (ø)
src/pymor/algorithms/to_matrix.py 99.17% <100.00%> (ø)
src/pymor/discretizers/builtin/list.py 84.84% <100.00%> (ø)
src/pymor/operators/interface.py 86.20% <100.00%> (ø)
... and 2 more

@pmli pmli requested a review from sdrave August 7, 2020 08:19
sdrave
sdrave reviewed Aug 17, 2020
View changes
Copy link
Member

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe it would be nice to have functions Concatenation etc. which are marked with @deprecated for the next release.

@pmli
Copy link
Member Author

pmli commented Aug 17, 2020

Maybe it would be nice to have functions Concatenation etc. which are marked with @deprecated for the next release.

Agreed. Does it look ok?

@renefritze
Copy link
Member

Should we maybe start to a running list of deprecations in the release notes? Would make writing them a bit simlper.

@pmli
Copy link
Member Author

pmli commented Aug 17, 2020

Should we maybe start to a running list of deprecations in the release notes? Would make writing them a bit simlper.

Sounds good to me. I've added a remark to the release notes.

@pmli pmli requested a review from sdrave August 26, 2020 08:51
sdrave
sdrave requested changes Aug 26, 2020
View changes
src/pymor/discretizers/builtin/fv.py Outdated Show resolved Hide resolved
src/pymor/operators/constructions.py Outdated Show resolved Hide resolved
src/pymor/operators/constructions.py Outdated Show resolved Hide resolved
src/pymor/basic.py Outdated Show resolved Hide resolved
sdrave
sdrave approved these changes Aug 26, 2020
View changes
@pmli pmli merged commit 85fc34b into master Aug 27, 2020
2 checks passed
@pmli pmli deleted the operator-names branch August 27, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrave sdrave sdrave approved these changes

Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2020.2
Development

Successfully merging this pull request may close these issues.

Inconsistencies in class naming
3 participants
@pmli @renefritze @sdrave