New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate dot/pairwise_dot in favor of inner/pairwise_inner #1066
Conversation
Ok, now I see that issue you were referring to in one of the meetings: every subclass of the |
That's totally fine. However, I am starting to be increasingly concerned about my statement
If
I would like to decide how to proceed in that regard before merging this PR as 2. might have some further consequences regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to rebase on master to get rid of the install_checks stage error on gitlab.
I would currently favor option 1. My last experiment with attaching a dtype to vectorspaces brought up enough issues that not-passing product ars around is not a good-enough upside to try something somewhat similar right now. |
Yes, I thought about this some more. There are two different layers:
Doing only 1. would still force us to keep the Also doing 2. probably results in a nightmare when So overall, I decided to add a commit, which clarifies that BTW, after this has been merged, I would also like to drop |
Codecov Report
|
As proposed in #930, this PR deprecates the
dot
andpairwise_dot
methods ofVectorArray
which are equivalent to callinginner
orpairwise_inner
without aproduct
argument.Any reservations @pymor/pymor-devs?
Note that currently we don't explicitly state anywhere that
inner
without aproduct
is the Euclidean inner product. I would like to keep it that way as there might be use cases, where you want to implementinner
with some 'special' product. (We already had several discussion about removing theproduct
arguments and equippingVectorSpaces
withproducts
. I'm still not convinced that this is the right thing to do, but I at least want to have an open door for hacks in that direction.)