Deprecate l2_norm/l2_norm2 in favor of norm/norm2 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefritze
reviewed
Aug 31, 2020
| @@ -407,7 +407,7 @@ def pairwise_inner(self, other, product=None): | |||
|
|
|||
| @Deprecated(pairwise_inner) | |||
| def pairwise_dot(self, other): | |||
| return self.pariwise_inner(other) | |||
| return self.pairwise_inner(other) | |||
There was a problem hiding this comment.
Seems this was never exercised in tests before, is pairwise_inner now?
There was a problem hiding this comment.
No. Maybe it was not so wise to remove the test for pairwise_dot. Was too lazy to open a separate PR for this.
Codecov Report
|
renefritze
approved these changes
Aug 31, 2020
HenKlei
approved these changes
Sep 1, 2020
pmli
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Following #1066, the implementations of
VectorArray.l2_norm,VectorArray.l2_norm2are moved to private_norm,_norm2methods.l2_normandl2_norm2are deprecated so that there is only one method to compute the Euclidean norm of aVectorArray. What that means (the Euclidean norm of thedofsof the array) is clarified in the docstring.Moreover,
almost_equalhas been simplified by replacing the (unused)normparameter by thesup_normparameter.