Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve projection of ConcatenationOperator #1102

Merged
merged 1 commit into from Sep 24, 2020
Merged

Improve projection of ConcatenationOperator #1102

merged 1 commit into from Sep 24, 2020

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Sep 24, 2020

This PR in particular allows to properly project LincombOperator @ VectorOperator as needed for handling non-zero Dirichlet boundaries.

@sdrave sdrave added the pr:new-feature Introduces a new feature label Sep 24, 2020
@sdrave sdrave added this to the 2020.2 milestone Sep 24, 2020
@sdrave sdrave requested a review from pmli September 24, 2020 14:30
@codecov
Copy link

codecov bot commented Sep 24, 2020 •
edited

Codecov Report

Merging #1102 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted Files Coverage Δ
src/pymor/algorithms/projection.py 77.09% <57.14%> (-1.77%) ⬇️
src/pymor/bindings/fenics.py 81.48% <0.00%> (-0.80%) ⬇️
src/pymor/vectorarrays/numpy.py 84.72% <0.00%> (+0.23%) ⬆️
src/pymor/vectorarrays/list.py 84.38% <0.00%> (+0.57%) ⬆️

pmli
pmli approved these changes Sep 24, 2020
View changes
@sdrave sdrave merged commit 5d99181 into master Sep 24, 2020
2 checks passed
@sdrave sdrave deleted the improve_project_concatenation branch September 24, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

Assignees
No one assigned
Labels
pr:new-feature Introduces a new feature
Projects
None yet
Milestone
2020.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdrave @pmli