Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changing number of POD modes for POD-greedy less error prone #1103

merged 1 commit into from Sep 24, 2020


Copy link

@sdrave sdrave commented Sep 24, 2020

Currently, specifying extension_params={'pod_modes': 5} for rb_greedy causes gram_schmidt to be chosen as extension algorithm instead of POD. This PR changes the behavior to always use POD for solution snapshots with more than one vector unless another extension_method is explicitly specified.

@sdrave sdrave added pr:change Change in existing functionality automerge labels Sep 24, 2020
@sdrave sdrave added this to the 2020.2 milestone Sep 24, 2020
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1103 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/pymor/algorithms/ 85.45% <100.00%> (+0.26%) ⬆️
src/pymor/vectorarrays/ 84.00% <0.00%> (+0.19%) ⬆️
src/pymor/vectorarrays/ 84.72% <0.00%> (+0.23%) ⬆️

@github-actions github-actions bot merged commit b3ba6ac into master Sep 24, 2020
2 checks passed
@github-actions github-actions bot deleted the improve_pod_greedy_params branch September 24, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
pr:change Change in existing functionality
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant