Skip to content

decompose output functional in discretizer #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

TiKeil
Copy link

@TiKeil TiKeil commented Oct 1, 2020

fixes #1111

@sdrave sdrave added the pr:new-feature Introduces a new feature label Oct 1, 2020
@sdrave sdrave added this to the 2020.2 milestone Oct 1, 2020
Copy link
Member

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two stylistic things:

  • The indentation in the list comprehensions look weird. The for should be aligned with the L/``B` in the line above. (Everything else would be rejected by my linter. At least it should be indented by a multiple of 4.)

  • I think I have never seen v_ before. AFAIK a trailing underscore is only used for keywords. I would probably use vv or so.

@TiKeil
Copy link
Author

TiKeil commented Oct 1, 2020

Only two stylistic things:

* The indentation in the list comprehensions look weird. The `for` should be aligned with the `L`/``B` in the line above. (Everything else would be rejected by my linter. At least it should be indented by a multiple of 4.)

* I think I have never seen `v_` before. AFAIK a trailing underscore is only used for keywords. I would probably use `vv` or so.

Sounds good. I have changed the code appropriately

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #1112 into master will decrease coverage by 0.02%.
The diff coverage is 45.45%.

Impacted Files Coverage Δ
src/pymor/discretizers/builtin/cg.py 89.07% <45.45%> (-0.86%) ⬇️
src/pymor/vectorarrays/list.py 84.00% <0.00%> (-0.39%) ⬇️
src/pymor/vectorarrays/numpy.py 84.72% <0.00%> (+0.23%) ⬆️

@sdrave sdrave added automerge and removed automerge labels Oct 1, 2020
@renefritze renefritze merged commit c29a64d into pymor:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature Introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discretize_cg does not support offline/online decomp. of output functional.
3 participants