Prevent corruption of memory cache #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renefritze
requested changes
Oct 27, 2020
There was a problem hiding this comment.
Could we try to trim down @ftalbrecht's example code that exhibited the error and add it as a test case?
|
@renefritze, the Enforce PR labels thing is failing again. We had similar issues some time ago. Maybe we should disable it? |
Codecov Report
|
renefritze
approved these changes
Oct 27, 2020
Lets see if the update fixing the run first |
ftalbrecht
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
MemoryRegionto always make adeepcopyof any values stored in the cache and to only return deep copies of the values contained in the cache. While this may increase the memory footprint and somewhat hurt performance, it seems like the only way to make usingMemoryRegionreally safe. The practical impact of the increased memory usage should be quite small, IMHO.Note that the current provisions of returning copies of
VectorArraysand making NumPy arrays immutable had no effect since all values stored in the cache are actually 2-tuples.See #1133 for a non-obvious real world example of
MemoryRegionbeing corrupted.