Always initialize mass and rhs attributes of InstationaryModel #1137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftalbrecht
approved these changes
Oct 28, 2020
| U = self.time_stepper.solve(operator=self.operator, | ||
| rhs=None if isinstance(self.rhs, ZeroOperator) else self.rhs, | ||
| initial_data=U0, | ||
| mass=None if isinstance(self.mass, IdentityOperator) else self.mass, |
There was a problem hiding this comment.
Would it not be nicer to not have the check here and instead extend the check/switch in the timestepper? It already checks for None and could also check for IdentityOperator or ZeroOperator, respectively.
There was a problem hiding this comment.
Yeah, maybe, but I didn't want to touch the time steppers in this pr.
renefritze
force-pushed
the
mass_not_none
branch
from
945bf8d to
dfac787
Compare
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
InstationaryModelis instantiated withmass=Noneorrhs=None, this PR causes corresponding attributes to be initialized with an appropriateIdentityOperatororZeroOperator. In particular, this is in agreement with the behavior ofLTIModel.Also see #1121.