Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor project_to_subbasis improvements #1138

merged 8 commits into from Nov 3, 2020


Copy link

@sdrave sdrave commented Oct 27, 2020

  • Added tests.
  • Actions for SeclectionOperator, ZeroOperator, VectorArrayOperator, BlockRowOperator, BlockColumnOperator.
  • Detect case when dim_range is None and dim_source is None.
  • Ensure that ids are preserved when projection NumpyMatrixOperator.

@sdrave sdrave added the pr:new-feature Introduces a new feature label Oct 27, 2020
@sdrave sdrave added this to the 2020.2 milestone Oct 27, 2020
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1138 into master will decrease coverage by 0.29%.
The diff coverage is 32.25%.

Impacted Files Coverage Δ
src/pymor/algorithms/ 50.00% <32.25%> (-27.66%) ⬇️
src/pymor/vectorarrays/ 84.19% <0.00%> (+0.19%) ⬆️

@sdrave sdrave mentioned this pull request Oct 28, 2020
@renefritze renefritze merged commit 69df80c into master Nov 3, 2020
2 checks passed
@renefritze renefritze deleted the improve_project_to_subbasis branch November 3, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
pr:new-feature Introduces a new feature
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants