Minor project_to_subbasis improvements #1138

sdrave · 2020-10-27T15:05:46Z

Added tests.
Actions for SeclectionOperator, ZeroOperator, VectorArrayOperator, BlockRowOperator, BlockColumnOperator.
Detect case when dim_range is None and dim_source is None.
Ensure that ids are preserved when projection NumpyMatrixOperator.

codecov · 2020-10-27T17:15:41Z

Codecov Report

Merging #1138 into master will decrease coverage by 0.29%.
The diff coverage is 32.25%.

Impacted Files	Coverage Δ
src/pymor/algorithms/projection.py	`50.00% <32.25%> (-27.66%)`	⬇️
src/pymor/vectorarrays/list.py	`84.19% <0.00%> (+0.19%)`	⬆️

sdrave added the pr:new-feature Introduces a new feature label Oct 27, 2020

sdrave added this to the 2020.2 milestone Oct 27, 2020

sdrave mentioned this pull request Oct 28, 2020

Watch Codecov Bot #1131

Closed

sdrave added 8 commits November 3, 2020 17:41

[tests] move project tests to algorithms.projection

345033c

[tests] add tests for project_to_subbasis

bd53f3e

[project_to_subbasis] do nothing when dim_range and dim_source are None

6e032cf

[project_to_subbasis] keep ids when projecting NumpyMatrixOperator

3f1873b

[project_to_subbasis] handle SelectionOperator

ea6f95e

[project_to_subbasis] handle ZeroOperator

e216544

[project_to_subbasis] handle VectorArrayOperator

ae54be6

[project_to_subbasis] handle BlockRowOperator/BlockColumnOperator

102761c

renefritze force-pushed the improve_project_to_subbasis branch from 9cf0db4 to 102761c Compare November 3, 2020 16:42

renefritze merged commit 69df80c into master Nov 3, 2020
2 checks passed

renefritze deleted the improve_project_to_subbasis branch November 3, 2020 20:00