Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement as_source_array/as_range_array for sparse NumpyMatrixOperators #1139

merged 3 commits into from Nov 4, 2020


Copy link

@sdrave sdrave commented Oct 27, 2020

Also add a guard to let the default implementation of as_source_array/as_range_array fail when the resulting array might be too large.

Fixes #1096. @meretp, does this work for you?

@sdrave sdrave added the pr:new-feature Introduces a new feature label Oct 27, 2020
@sdrave sdrave added this to the 2020.2 milestone Oct 27, 2020
@sdrave sdrave requested a review from lbalicki October 27, 2020 15:52
Copy link

meretp commented Oct 27, 2020

Works fine for me. Thanks.

Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #1139 into master will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted Files Coverage Δ
src/pymor/operators/ 80.09% <50.00%> (+0.49%) ⬆️
src/pymor/operators/ 85.80% <85.71%> (+0.54%) ⬆️
src/pymor/bindings/ 84.32% <0.00%> (-0.75%) ⬇️
src/pymor/vectorarrays/ 84.48% <0.00%> (-0.24%) ⬇️
src/pymor/vectorarrays/ 84.00% <0.00%> (ø)
src/pymor/operators/ 88.71% <0.00%> (+0.55%) ⬆️

Copy link

ping @lbalicki

@sdrave sdrave merged commit a011cd1 into master Nov 4, 2020
2 checks passed
@renefritze renefritze deleted the improve_as_array branch November 4, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
pr:new-feature Introduces a new feature
None yet

Successfully merging this pull request may close these issues.

NotImplementedError for sparse NumpyMatrixOperator
4 participants