Implement as_source_array/as_range_array for sparse NumpyMatrixOperators #1139

sdrave · 2020-10-27T15:52:34Z

Also add a guard to let the default implementation of as_source_array/as_range_array fail when the resulting array might be too large.

Fixes #1096. @meretp, does this work for you?

meretp · 2020-10-27T16:52:00Z

Works fine for me. Thanks.

codecov · 2020-10-27T17:38:01Z

Codecov Report

Merging #1139 into master will increase coverage by 0.02%.
The diff coverage is 77.77%.

Impacted Files	Coverage Δ
src/pymor/operators/numpy.py	`80.09% <50.00%> (+0.49%)`	⬆️
src/pymor/operators/interface.py	`85.80% <85.71%> (+0.54%)`	⬆️
src/pymor/bindings/ngsolve.py	`84.32% <0.00%> (-0.75%)`	⬇️
src/pymor/vectorarrays/numpy.py	`84.48% <0.00%> (-0.24%)`	⬇️
src/pymor/vectorarrays/list.py	`84.00% <0.00%> (ø)`
src/pymor/operators/constructions.py	`88.71% <0.00%> (+0.55%)`	⬆️

…urce/range dims

renefritze · 2020-11-03T20:18:53Z

sdrave added the pr:new-feature Introduces a new feature label Oct 27, 2020

sdrave added this to the 2020.2 milestone Oct 27, 2020

sdrave requested a review from lbalicki October 27, 2020 15:52

sdrave added 3 commits November 3, 2020 17:41

[Operator] guard as_array default implementaions against too large so…

1bc36e7

…urce/range dims

[NumpyMatrixOperator] implement as_array methods for sparse matrices

29f8baa

[tests] add tests for as_source_array/as_range_array

80f7b37

renefritze force-pushed the improve_as_array branch from d5dc593 to 80f7b37 Compare November 3, 2020 16:41

lbalicki approved these changes Nov 3, 2020

View changes

sdrave merged commit a011cd1 into master Nov 4, 2020
2 checks passed

renefritze deleted the improve_as_array branch November 4, 2020 09:45