Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove notebooks dir #1160

Merged
merged 5 commits into from
Nov 18, 2020
Merged

remove notebooks dir #1160

merged 5 commits into from
Nov 18, 2020

Conversation

renefritze
Copy link
Member

This removes testing infrastructure for the notebooks subdirectory
and nbconverts all notebooks to demos that did not already have a matching demo.

@github-actions github-actions bot added the infrastructure Buildsystem, packages and CI label Nov 17, 2020
@renefritze renefritze added the pr:removal Removes a feature label Nov 17, 2020
@renefritze renefritze added this to the 2020.2 milestone Nov 17, 2020
@renefritze
Copy link
Member Author

renefritze commented Nov 17, 2020

I've based this in the typer branch to avoid CI conflicts, so this should only be merged after #1118

@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #1160 (52e900f) into master (f7de9eb) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/pymor/bindings/ngsolve.py 83.84% <0.00%> (-0.77%) ⬇️
src/pymor/vectorarrays/numpy.py 84.29% <0.00%> (-0.25%) ⬇️
src/pymor/vectorarrays/list.py 82.99% <0.00%> (ø)

@renefritze renefritze self-assigned this Nov 18, 2020
@renefritze
Copy link
Member Author

My plan is to merge this ASAP and let @pmli take over making the "new" demos into something actually useful/useable.

Sound good?

@sdrave
Copy link
Member

sdrave commented Nov 18, 2020

I think before merging this, we should hook up the new demos into our testing infrastructure. For that one only would have to make each new demo a (trivial) typer app and add corresponding lines to SYS_MOR_ARGS in pymortests.demos.

@renefritze
Copy link
Member Author

I think before merging this, we should hook up the new demos into our testing infrastructure. For that one only would have to make each new demo a (trivial) typer app and add corresponding lines to SYS_MOR_ARGS in pymortests.demos.

That's easier todo when one actually makes the demos work anyhow. As is they might block execution due to non-NB visualization.

@sdrave
Copy link
Member

sdrave commented Nov 18, 2020

So why do yo want to merge before the demos actually work? Do you have any reason to believe that the matplotlib hack in _test_demo won't work?

@renefritze
Copy link
Member Author

As I explained in chat already, problems with the testing infra for notebooks currently interferes with the work I do on #876 and generally I did not want to solve problems with the demos now that might not even be there after @pmli changes them. Blocking show was just an example.

@sdrave
Copy link
Member

sdrave commented Nov 18, 2020

Ok.

@sdrave sdrave merged commit ccd80c1 into master Nov 18, 2020
@sdrave sdrave deleted the nb_move branch November 18, 2020 13:02
@sdrave sdrave mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Buildsystem, packages and CI pr:removal Removes a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants