-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove notebooks dir #1160
remove notebooks dir #1160
Conversation
I've based this in the typer branch to avoid CI conflicts, so this should only be merged after #1118 |
Codecov Report
|
all other demos already had a demo twin
My plan is to merge this ASAP and let @pmli take over making the "new" demos into something actually useful/useable. Sound good? |
I think before merging this, we should hook up the new demos into our testing infrastructure. For that one only would have to make each new demo a (trivial) typer app and add corresponding lines to |
That's easier todo when one actually makes the demos work anyhow. As is they might block execution due to non-NB visualization. |
So why do yo want to merge before the demos actually work? Do you have any reason to believe that the matplotlib hack in |
Ok. |
This removes testing infrastructure for the notebooks subdirectory
and nbconverts all notebooks to demos that did not already have a matching demo.