Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sys-mor demos #1198

Merged
merged 6 commits into from Dec 3, 2020
Merged

Improve sys-mor demos #1198

merged 6 commits into from Dec 3, 2020

Conversation

pmli
Copy link
Member

@pmli pmli commented Dec 1, 2020

This PR does some major changes in sys-mor tutorials: adding more MOR methods, improving consistency across demos, and removing some code duplication and unneeded plots. Also, it reduces problem dimensions for system testing.

@pmli pmli added the pr:change Change in existing functionality label Dec 1, 2020
@pmli pmli added this to the 2020.2 milestone Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1198 (3ed84b3) into master (4085263) will decrease coverage by 0.13%.
The diff coverage is 99.39%.

Impacted Files Coverage Δ
src/pymordemos/heat.py 95.77% <97.36%> (+1.10%) ⬆️
src/pymordemos/delay.py 96.87% <100.00%> (-1.78%) ⬇️
src/pymordemos/parametric_delay.py 97.82% <100.00%> (-0.51%) ⬇️
src/pymordemos/parametric_heat.py 98.88% <100.00%> (-0.32%) ⬇️
src/pymordemos/parametric_string.py 98.79% <100.00%> (-0.91%) ⬇️
src/pymordemos/parametric_synthetic.py 98.46% <100.00%> (-0.61%) ⬇️
src/pymordemos/string_equation.py 97.10% <100.00%> (+1.25%) ⬆️
src/pymortests/demos.py 88.67% <100.00%> (+0.48%) ⬆️
src/pymor/bindings/ngsolve.py 82.08% <0.00%> (-2.53%) ⬇️
src/pymor/bindings/slycot.py 92.30% <0.00%> (-1.93%) ⬇️
... and 59 more

@pmli pmli marked this pull request as ready for review December 1, 2020 20:39
@pmli pmli requested review from sdrave and lbalicki December 1, 2020 20:39
sdrave
sdrave approved these changes Dec 2, 2020
Copy link
Member

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use this a lot, one might consider moving (a version of) run_mor_method(_param) to pymor.algorithms.error ..

@pmli
Copy link
Member Author

pmli commented Dec 2, 2020

If you use this a lot, one might consider moving (a version of) run_mor_method(_param) to pymor.algorithms.error ..

I just used it in a few demos, but it could be worth considering having a version in algorithms.error with more features.

@pmli pmli merged commit aa3011a into master Dec 3, 2020
2 checks passed
@pmli pmli deleted the sys-mor-demos branch December 3, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change Change in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants