-
Notifications
You must be signed in to change notification settings - Fork 114
Tutorial for optimization #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice tutorial! Only some minor remarks from my side...
Thanks for the very nice review. I already included all comments. |
68ac407
to
a14a988
Compare
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this is a very nice tutorial! But maybe try to give a more direct and positive answer to: 'I have a PDE-constrained optimization problem, and I want to use pyMOR for speedup. What should I try as a first step?' Reading through the very long text, at the end you might get the impression that only an open problem has been presented. You should have a feeling of achievement.
0706b88
to
9de4b39
Compare
Thanks @sdrave for the very nice and detailed review. I have addressed all your points except the citations. I think, the text in the end reads way more positive now. I will see how I can improve this more but it should be okay already. Removing Draft mode. |
Looking good 👍 Also, can you do me a favor and also fix a typo in the mybinder box?
|
9de4b39
to
45a9968
Compare
Hey @TiKeil it looks like this PR touches our CI config (and you are not in my contributor safelist), therefore I am not starting a gitlab-ci build for it and it will not be mergeable. |
Thanks, I have fixed the typo and increased the timeout limit. Furthermore I have added my last changes. Thus, this can be merged if there are no other objections. |
You could also add the references to the bibliography file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greenlight for CI again
I intentionally did not do that because these references do not have anything to do with algorithms or implementational features in |
Ah okay, sounds reasonable. |
1d7ce56
to
21bb834
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing everything, I suggest to
- go through the intro once and unify the number of whitespace lines between the code and the text (say one before/after code blocks and two before headlines) and
- check the indentation of the code examples, in particular the creation of the data dicts.
Thanks @ftalbrecht, I have added the files accordingly. Some of your remarks were outdated already such that I could not apply all requested changes. |
3eab696
to
a040d4b
Compare
This PR contains a very detailed tutorial for optimization. The content is highly related to my talk on the online pymor school 2020.
I will rebase this PR after #1110 has been merged. So please ignore all commits except the last two and only look at this file.
@pymor/all it would be nice if you could read through it, there might be some typos or other issues.
Let me know what you think.