New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to models.iosys
for exporting matrices
#1309
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, could you remove the type annotations for now? I don't think it is quite clear at the moment if/when we will have type annotations in pyMOR ..
I removed the type annotations now. I also realized that probably |
I like the current setup as it forces one to consider backwards compat. Maybe we could use the saved (or a new set, since that'll be easier) compare files also for a check if |
This PR adds
to_*
methods toLTIModel
andSecondOrderModel
, tests forfrom_*
andto_*
methods, and output methods totools.io
. The tests should cover most of what is not covered by #1300 inmodels.iosys
. I'm not sure how the CI will react to creating temporary files; I guess we'll see.