Parallelize greedy algorithm #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distribute -> push distribute_array -> scatter_array distribute_list -> scatter_list
and use DummyPool to have only on code path for both the sequential and parallel case.
| else: | ||
| logger.info('Using pool of {} workers for parallel greedy search'.format(len(pool))) | ||
|
|
||
| with RemoteObjectManager() as rom: |
There was a problem hiding this comment.
rom may be a misleading name in the context of model reduction (reduced order model), but it is probably unproblematic in this local context...
|
|
|
With #148 merged, I would propose to merge this one as well. I guess, the implementation could still use some testing, but it gets more testing if its in master and 0.4 is still some way ahead ... |
|
agreed, go ahead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the (updated) parallelized version of
pymor.algorithms.greedyfrom the pymor-paper branch.