Simplify VectorArray implementations #1584
Conversation
sdrave
force-pushed
the
simplify_vectorarray_impl
branch
from
e27832a
to
cf4e6bd
Compare
Codecov Report
|
| :class:`BlockVectorArray` can be used in conjunction with | ||
| :class:`~pymor.operators.block.BlockOperator`. | ||
| """ | ||
| class BlockVectorArrayImpl(VectorArrayImpl): |
There was a problem hiding this comment.
Is this class referenced elsewhere in a docstring? Should it get one that maybe just refers to the VectorArrayImpl?
There was a problem hiding this comment.
No, it isn't. I don't think that adding a docstring here is necessary since a regular user should not be exposed to this class. I'd rather require docstrings also for internal classes.
| :class:`~pymor.bindings.ngsolve.NGSolveVector` and | ||
| :class:`~pymor.bindings.ngsolve.NGSolveVectorSpace`. | ||
| """ | ||
| class ListVectorArrayImpl(VectorArrayImpl): |
| return self.__class__([v.conj() for v in self._list], self.space) | ||
|
|
||
| class ListVectorArray(VectorArray): | ||
| """|VectorArray| implemented as a Python list of vectors. |
There was a problem hiding this comment.
For similar reasons as above, I'd prefer to not do it.
|
Same comments for the MPI and numpy arrays too. |
|
Looks good. However, could you give a brief motivation for this change? Do I understand it correctly that more work is done in the base classes and less work needs to be done in the actual implementations (bluntly speaking)? |
The main reason is that the current implementations are quite complicated and it seems daunting to implement a new |
This refactors
VectorArrayto defer all interface methods to operations on an internalVectorArrayImplobject.VectorArrayitselfs manages copy-on-write semantics, the handling ofproductarguments, error checking and the handling of views.Additionally the following changes have been made:
VectorObjectsstored in aListVectorArraysis now provided via thevectorsproperty. The old name_listis deprecated.BlockVectorArraycan be accessed via theblocksproperty. No copy is made. Theblocksmethod and thenum_blocksproperty have been deprecated. To ensure that the user does not append to/delete from blocks they have accessed viaU.blockseach method ofBlockVectorArrayImplnow asserts_blocks_are_validwhich produces a helpful error message.