Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different colormaps in GLPatchWidget #176

Merged
merged 1 commit into from Oct 20, 2016
Merged

Support different colormaps in GLPatchWidget #176

merged 1 commit into from Oct 20, 2016

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 4, 2015

This is some work I have done a while ago. We still need to wire everything up ...

@landscape-bot
Copy link

@landscape-bot landscape-bot commented Nov 4, 2015

Code Health
Repository health increased by 4% when pulling 6c121ec on colormap into 98b014e on master.

@sdrave sdrave added this to the 0.5 milestone Nov 13, 2015
@sdrave sdrave force-pushed the colormap branch from 4740163 to 209adc4 Oct 19, 2016
@sdrave sdrave force-pushed the colormap branch from 0105dac to 033bb17 Oct 19, 2016
@sdrave
Copy link
Member Author

@sdrave sdrave commented Oct 19, 2016

I have now finished the colormap support and defaulted the new colormap to viridis. Please, everyone, have a look if the new code works correctly on your machine.

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Oct 20, 2016

thermalblock_gui.py seems to work as expected under arch linux. Anything else I should test?

@sdrave
Copy link
Member Author

@sdrave sdrave commented Oct 20, 2016

Since thermalblock_gui.py is special case, better also have a look at thermalbock.py and burgers.py.

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Oct 20, 2016

./thermalblock.py --plot-err --plot-solutions --plot-error-sequence ... and ./burgers.py ... work for me.

@renefritze
Copy link
Member

@renefritze renefritze commented Oct 20, 2016

All three look good for me

@pmli
Copy link
Member

@pmli pmli commented Oct 20, 2016

(If you're happy, I'm happy.)

@sdrave sdrave merged commit 2e7e211 into master Oct 20, 2016
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.2%) to 81.368%
Details
code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sdrave sdrave deleted the colormap branch Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants