[cache] add 'cached_method_call' and use it in DiscretizationInterface.solve #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cached_method_call allows to call a method of an CacheableInterface instance with caching, even when the method has not been decorated with 'cached'.
This allows us to call parse_parameter on mu before passing it to the cache key generation, making cache lookup more robust.
|
@ftalbrecht, this is what we had discussed earlier for the LRBMS code. |
|
Yes, very nice! |
sdrave
added a commit
that referenced
this pull request
Mar 10, 2016
[cache] add 'cached_method_call' and use it in DiscretizationInterface.solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a cache miss for the second
solvecall in the following example, sinceparse_parameteris now called before handing the arguments to the caching code.