Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l2_norm2 methods #237

Merged
merged 6 commits into from May 4, 2016
Merged

l2_norm2 methods #237

merged 6 commits into from May 4, 2016

Conversation

@pmli
Copy link
Member

@pmli pmli commented Apr 26, 2016

See #236

@coveralls
Copy link

@coveralls coveralls commented Apr 26, 2016

Coverage Status

Coverage decreased (-0.1%) to 80.874% when pulling a114cc9 on pmli:l2_norm2 into f127477 on pymor:master.

@sdrave sdrave added this to the 0.5 milestone Apr 26, 2016
@coveralls
Copy link

@coveralls coveralls commented Apr 26, 2016

Coverage Status

Coverage decreased (-0.06%) to 80.959% when pulling 998d96b on pmli:l2_norm2 into f127477 on pymor:master.

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Apr 26, 2016

Looks good to me, thanks for the work! Given the Python 3 transition which is on the way, do we want to include these changes beforehand, @sdrave?

@sdrave
Copy link
Member

@sdrave sdrave commented May 3, 2016

LGTM as well. @renemilk, do you have any objections on merging this before the Python 3 transition?

@sdrave sdrave merged commit 64225be into pymor:master May 4, 2016
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.06%) to 80.959%
Details
code-quality/landscape Code quality remained the same
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sdrave
Copy link
Member

@sdrave sdrave commented May 4, 2016

Thanks again! I have updated AUTHORS.md in 0cd2c53.

@pmli pmli deleted the pmli:l2_norm2 branch May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants