Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor analyticalproblems #312

Merged
merged 5 commits into from Oct 26, 2016
Merged

Refactor analyticalproblems #312

merged 5 commits into from Oct 26, 2016

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Oct 25, 2016

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Oct 25, 2016

Coverage Status

Coverage decreased (-0.1%) to 81.084% when pulling d432be9 on refactor_analyticalproblems into 5d06790 on master.

Parameters
----------
num_blocks
The tuple `(nx, ny)`
parameter_range
A tuple `(μ_min, μ_max)`. Each |Parameter| component μ_ij is allowed
to lie in the interval [μ_min, μ_max].
rhs
The |Function| f(x, μ).
Copy link
Member

@ftalbrecht ftalbrecht Oct 26, 2016

Any reasons for dropping the optional rhs argument?

Copy link
Member Author

@sdrave sdrave Oct 26, 2016

Since one now can simply write thermal_block_problem().with_(rhs=...) I see no need to have this as an extra argument.

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Oct 26, 2016

lgtm

@sdrave sdrave merged commit 1889790 into master Oct 26, 2016
3 checks passed
@sdrave sdrave deleted the refactor_analyticalproblems branch Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants