New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge analyticalproblems and discretizers #337

Merged
merged 5 commits into from Jan 11, 2017

Conversation

Projects
None yet
1 participant
@sdrave
Copy link
Member

sdrave commented Dec 16, 2016

This pull request does the following:

  • InstationaryAdvectionProblem(...) -> InstantionaryProblem(EllipticProblem(...), ...)
  • discretize_parabolic_fv + discretize_nonlinear_instationary_advection_fv -> discretize_instationary_fv
  • rename:
    • discretize_elliptic_fv -> discretize_stationary_fv
    • discretize_elliptic_cg -> discretize_stationary_cg
    • discretize_parabolic_cb -> discretize_instationary_cg

I would still like to give EllipticProblem a better name. Any ideas?

@sdrave sdrave added this to the 0.5 milestone Dec 16, 2016

@sdrave sdrave force-pushed the analyticalproblem_refactor branch from b5cd5e0 to 7eeac5f Jan 10, 2017

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Jan 10, 2017

There seems to be no really good name. We decided to go with StationaryProblem as 'not specific enough' is better than 'too specific'.

@sdrave sdrave merged commit f63a0cc into master Jan 11, 2017

4 checks passed

code-quality/landscape Code quality decreased by -0.20%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.871%
Details

@sdrave sdrave deleted the analyticalproblem_refactor branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment