Introduce 'bindings' package #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Would be nice to see how DUNE integrates into this... |
|
@ftalbrecht, what do you mean by that? |
|
That I cannot say more than LGTM until I have written bindings for dune-gdt, which should happen within the new weeks, hopefully... |
|
Ok, but what could be specific about dune that would make placing bindings in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new 'pymor.bindings' package which is supposed to contain all glue code to interface with external high-dimensional solver libraries. These can be PDE solvers (fenics, dealii, ngsolve, dune, etc.), as well as equation solvers (scipy, pyamg, slycot, pymess, etc.)
In general, code in 'pymor.bindings' has the purpose of either translating pyMOR objects (
Operators,VectorArrays,Discretizations) to objects understood by the external library (e.g. convert a linear Operator to a matrix of appropriate format), or to wrap objects of the external library to comply to pyMOR's interfaces (e.g. to integrate an external PDE solver with pyMOR).@ftalbrecht, @pmli, please take a look if you are ok with the new design. As we have discussed in #291,
the glue code for slycot and pymess would go into
solve_lyapmethods located inpymor.bindings.slycotandpymor.bindings.pymessmodules.