Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'bindings' package #353

Merged
merged 2 commits into from Jan 11, 2017
Merged

Introduce 'bindings' package #353

merged 2 commits into from Jan 11, 2017

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Jan 10, 2017

This pull request introduces a new 'pymor.bindings' package which is supposed to contain all glue code to interface with external high-dimensional solver libraries. These can be PDE solvers (fenics, dealii, ngsolve, dune, etc.), as well as equation solvers (scipy, pyamg, slycot, pymess, etc.)

In general, code in 'pymor.bindings' has the purpose of either translating pyMOR objects (Operators, VectorArrays, Discretizations) to objects understood by the external library (e.g. convert a linear Operator to a matrix of appropriate format), or to wrap objects of the external library to comply to pyMOR's interfaces (e.g. to integrate an external PDE solver with pyMOR).

@ftalbrecht, @pmli, please take a look if you are ok with the new design. As we have discussed in #291,
the glue code for slycot and pymess would go into solve_lyap methods located in pymor.bindings.slycot and pymor.bindings.pymess modules.

@sdrave sdrave added this to the 0.5 milestone Jan 10, 2017
@sdrave sdrave force-pushed the bindings branch from ba59b36 to 2c12874 Jan 10, 2017
@sdrave sdrave force-pushed the bindings branch from 2c12874 to 0ab9536 Jan 10, 2017
@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Jan 10, 2017

LGTM. Would be nice to see how DUNE integrates into this...

@sdrave
Copy link
Member Author

@sdrave sdrave commented Jan 10, 2017

@ftalbrecht, what do you mean by that?

@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Jan 10, 2017

That I cannot say more than LGTM until I have written bindings for dune-gdt, which should happen within the new weeks, hopefully...

@sdrave
Copy link
Member Author

@sdrave sdrave commented Jan 10, 2017

Ok, but what could be specific about dune that would make placing bindings in pymor.bindings inappropriate?

@sdrave sdrave merged commit 879f6c7 into master Jan 11, 2017
4 checks passed
4 checks passed
code-quality/landscape Code quality decreased by -0.02%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.005%) to 79.463%
Details
@sdrave sdrave deleted the bindings branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants