New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let BitmapFunction accept non-grayscale images #370

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
2 participants
@sdrave
Copy link
Member

sdrave commented May 9, 2017

Non-grayscale images are now automatically converted to grayscale. Also, we no longer use img.rawdata, which has been failing for some images.

@andreasbuhr, if you are currently actively using BitmapFunction, could you see if these changes work for you?

[BitmapFunction] accept non-grayscale images
and do not use rawdata to convert to numpy array
@andreasbuhr

This comment has been minimized.

Copy link
Contributor

andreasbuhr commented May 11, 2017

I guess it would be OK but I cannot test right now.

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented May 24, 2017

This has now been successfully tested by multiple users. Merging ...

@sdrave sdrave merged commit 64ee987 into master May 24, 2017

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.003%) to 78.831%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sdrave sdrave deleted the improve_bitmapfunction branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment