Skip to content

/ pymor Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NumpyMatrixOperator] rename '_matrix' attribute to 'matrix' #436

Merged
merged 1 commit into from Apr 18, 2018
Merged

[NumpyMatrixOperator] rename '_matrix' attribute to 'matrix' #436

merged 1 commit into from Apr 18, 2018

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Apr 17, 2018

Subclasses of ImmutableInterface should have equally-named attributes for their __init__ attributes. Otherwise a custom with_ implementation is needed. (Right now, NumpyMatrixOperator._with is broken.) Also, you often need access to the matrix attribute in interactive work, and tab completion will not show private attributes.

Any objections, @pymor/pymor-devs?
@sdrave sdrave added this to the 0.5 milestone Apr 17, 2018
@ftalbrecht
Copy link
Member

@ftalbrecht ftalbrecht commented Apr 17, 2018

no objections

@sdrave sdrave force-pushed the matrix_public_attr branch from fe949ec to 3923952 Apr 17, 2018
pmli
pmli reviewed Apr 18, 2018
View changes
src/pymor/algorithms/to_matrix.py Outdated Show resolved Hide resolved
pmli
pmli reviewed Apr 18, 2018
View changes
src/pymor/algorithms/to_matrix.py Outdated Show resolved Hide resolved
pmli
pmli reviewed Apr 18, 2018
View changes
src/pymor/algorithms/to_matrix.py Outdated Show resolved Hide resolved
pmli
pmli reviewed Apr 18, 2018
View changes
src/pymor/algorithms/to_matrix.py Outdated Show resolved Hide resolved
@sdrave
[NumpyMatrixOperator] rename '_matrix' attribute to 'matrix'
e1a3250
@sdrave sdrave force-pushed the matrix_public_attr branch from 3923952 to e1a3250 Apr 18, 2018
@sdrave sdrave merged commit 745b179 into master Apr 18, 2018
3 of 4 checks passed
@sdrave sdrave deleted the matrix_public_attr branch Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sdrave @ftalbrecht @pmli