[NumpyMatrixOperator] rename '_matrix' attribute to 'matrix' #436
+49
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no objections |
sdrave
force-pushed
the
matrix_public_attr
branch
from
fe949ec to
3923952
Compare
pmli
reviewed
Apr 18, 2018
pmli
reviewed
Apr 18, 2018
pmli
reviewed
Apr 18, 2018
pmli
reviewed
Apr 18, 2018
sdrave
force-pushed
the
matrix_public_attr
branch
from
3923952 to
e1a3250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclasses of
ImmutableInterfaceshould have equally-named attributes for their__init__attributes. Otherwise a customwith_implementation is needed. (Right now,NumpyMatrixOperator._withis broken.) Also, you often need access to thematrixattribute in interactive work, and tab completion will not show private attributes.Any objections, @pymor/pymor-devs?