Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[NumpyMatrixOperator] rename '_matrix' attribute to 'matrix' #436
Conversation
sdrave
added this to the 0.5 milestone
Apr 17, 2018
This comment has been minimized.
This comment has been minimized.
|
no objections |
sdrave
force-pushed the
matrix_public_attr
branch
from
fe949ec
to
3923952
Apr 17, 2018
pmli
reviewed
Apr 18, 2018
src/pymor/algorithms/to_matrix.py Outdated
pmli
reviewed
Apr 18, 2018
src/pymor/algorithms/to_matrix.py Outdated
pmli
reviewed
Apr 18, 2018
src/pymor/algorithms/to_matrix.py Outdated
pmli
reviewed
Apr 18, 2018
src/pymor/algorithms/to_matrix.py Outdated
sdrave
force-pushed the
matrix_public_attr
branch
from
3923952
to
e1a3250
Apr 18, 2018
sdrave
merged commit 745b179
into
master
Apr 18, 2018
3 of 4 checks passed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch
AppVeyor build succeeded
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
sdrave
deleted the
matrix_public_attr
branch
Apr 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sdrave commentedApr 17, 2018
Subclasses of
ImmutableInterfaceshould have equally-named attributes for their__init__attributes. Otherwise a customwith_implementation is needed. (Right now,NumpyMatrixOperator._withis broken.) Also, you often need access to thematrixattribute in interactive work, and tab completion will not show private attributes.Any objections, @pymor/pymor-devs?