Skip to content

[LincombOperator] implement 'apply_inverse' #437

Merged
sdrave merged 1 commit intomasterfrom
lincomb_apply_inverse
Apr 19, 2018
Merged

[LincombOperator] implement 'apply_inverse' #437
sdrave merged 1 commit intomasterfrom
lincomb_apply_inverse

Conversation

@sdrave
Copy link
Copy Markdown
Member

@sdrave sdrave commented Apr 18, 2018

and 'apply_inverse_transpose' for the special case of len(self.operators) == 1.

See discussion in #272.

@sdrave sdrave added this to the 0.5 milestone Apr 18, 2018
@sdrave sdrave requested a review from pmli April 18, 2018 10:37
else:
raise InversionError
else:
U = self.operator.apply_inverse(V, mu=mu, least_squares=least_squares)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.operator -> self.operators[0]

else:
raise InversionError
else:
V = self.operator.apply_inverse_transpose(U, mu=mu, least_squares=least_squares)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

…ose'

for the special case of len(self.operators) == 1
@sdrave sdrave force-pushed the lincomb_apply_inverse branch from 441024b to 3839ae7 Compare April 18, 2018 10:58
@sdrave
Copy link
Copy Markdown
Member Author

sdrave commented Apr 18, 2018

Oh dear, we really need a faster test suite ... - Should be fixed now.

@pmli
Copy link
Copy Markdown
Member

pmli commented Apr 18, 2018

When merging with master, everything works now.

@sdrave sdrave merged commit 2ab2782 into master Apr 19, 2018
@sdrave sdrave deleted the lincomb_apply_inverse branch April 19, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants