Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LincombOperator] implement 'apply_inverse' #437

Merged
merged 1 commit into from Apr 19, 2018
Merged

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Apr 18, 2018

and 'apply_inverse_transpose' for the special case of len(self.operators) == 1.

See discussion in #272.

@sdrave sdrave added this to the 0.5 milestone Apr 18, 2018
@sdrave sdrave requested a review from pmli Apr 18, 2018
else:
raise InversionError
else:
U = self.operator.apply_inverse(V, mu=mu, least_squares=least_squares)

This comment has been minimized.

@pmli

pmli Apr 18, 2018
Member

self.operator -> self.operators[0]

else:
raise InversionError
else:
V = self.operator.apply_inverse_transpose(U, mu=mu, least_squares=least_squares)

This comment has been minimized.

@pmli

pmli Apr 18, 2018
Member

See above.

…ose'

for the special case of len(self.operators) == 1
@sdrave sdrave force-pushed the lincomb_apply_inverse branch from 441024b to 3839ae7 Apr 18, 2018
@sdrave
Copy link
Member Author

@sdrave sdrave commented Apr 18, 2018

Oh dear, we really need a faster test suite ... - Should be fixed now.

@pmli
pmli approved these changes Apr 18, 2018
@pmli
Copy link
Member

@pmli pmli commented Apr 18, 2018

When merging with master, everything works now.

@sdrave sdrave merged commit 2ab2782 into master Apr 19, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sdrave sdrave deleted the lincomb_apply_inverse branch Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants