Fix VectorArrayOperator, generalize as_range/source_array #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdrave
reviewed
Apr 19, 2018
src/pymor/operators/constructions.py
Outdated
| if not all(isinstance(op, VectorArrayOperator) and op.transposed == transposed for op in operators): | ||
| space_id = operators[0].space_id | ||
| if not all(isinstance(op, VectorArrayOperator) and op.transposed == transposed and op.space_id == space_id | ||
| for op in operators): |
There was a problem hiding this comment.
I think it would be better to check if all source and range spaces are equal (==). In theory it is possible to assign the same space_id to different dimensional spaces (although probably a bad idea).
|
I made the change and rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the fixes from #433 which can be applied to master.