New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VectorArrayOperator, generalize as_range/source_array #438

Merged
merged 2 commits into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@pmli
Copy link
Member

pmli commented Apr 18, 2018

These are the fixes from #433 which can be applied to master.

@pmli pmli requested a review from sdrave Apr 18, 2018

@sdrave sdrave added this to the 0.5 milestone Apr 19, 2018

@sdrave sdrave added the bug label Apr 19, 2018

@sdrave
Copy link
Member

sdrave left a comment

Otherwise LGTM.

if not all(isinstance(op, VectorArrayOperator) and op.transposed == transposed for op in operators):
space_id = operators[0].space_id
if not all(isinstance(op, VectorArrayOperator) and op.transposed == transposed and op.space_id == space_id
for op in operators):

This comment has been minimized.

@sdrave

sdrave Apr 19, 2018

Member

I think it would be better to check if all source and range spaces are equal (==). In theory it is possible to assign the same space_id to different dimensional spaces (although probably a bad idea).

@pmli pmli force-pushed the fix-vao-ara-asa branch from 5943dd7 to 8daaa08 Apr 19, 2018

@pmli

This comment has been minimized.

Copy link
Member Author

pmli commented Apr 19, 2018

I made the change and rebased.

@sdrave sdrave merged commit db76bf8 into master Apr 19, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sdrave sdrave deleted the fix-vao-ara-asa branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment