New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'to_numpy' / 'from_numpy' methods #446

Merged
merged 12 commits into from Jul 4, 2018

Conversation

Projects
None yet
3 participants
@sdrave
Copy link
Member

sdrave commented Jul 2, 2018

This implements the proposal in #252.

@sdrave sdrave changed the title implement #252 Introduce 'to_numpy' / 'from_numpy' methods Jul 2, 2018

@sdrave sdrave requested a review from pmli Jul 2, 2018

@sdrave sdrave added this to the 0.5 milestone Jul 2, 2018

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Jul 2, 2018

@renemilk, we have again unsuccessful checks due to decreasing coverage :(

@pmli

pmli approved these changes Jul 2, 2018

Copy link
Member

pmli left a comment

I guess 0.03% decrease in coverage is not that significant.

sdrave and others added some commits Jul 2, 2018

@renefritze renefritze force-pushed the to_numpy branch from 3adaa02 to 0370c5d Jul 3, 2018

@pymor pymor deleted a comment from codecov bot Jul 3, 2018

@renefritze

This comment has been minimized.

Copy link
Member

renefritze commented Jul 3, 2018

I've deleted the codecov comment in the hope that it'll pop up with 'right' layout in a bit. What I don't understand atm is why #447 was apparently using the correct yaml, where here we got both the wrong comment layout and the disabled check.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #446 into master will increase coverage by 0.36%.
The diff coverage is 69.16%.

Impacted Files Coverage Δ
src/pymor/grids/oned.py 98.11% <ø> (ø) ⬆️
src/pymor/operators/interfaces.py 68.42% <ø> (ø) ⬆️
src/pymor/grids/tria.py 98.38% <ø> (ø) ⬆️
src/pymor/grids/rect.py 93.27% <ø> (ø) ⬆️
src/pymor/grids/unstructured.py 95.91% <ø> (ø) ⬆️
src/pymor/gui/jupyter.py 9.83% <0%> (ø) ⬆️
src/pymor/gui/qt.py 24.64% <0%> (ø) ⬆️
src/pymor/discretizers/fv.py 84% <0%> (ø) ⬆️
src/pymor/reductors/residual.py 71.89% <0%> (ø) ⬆️
src/pymor/algorithms/to_matrix.py 100% <100%> (ø) ⬆️
... and 20 more
@renefritze

This comment has been minimized.

Copy link
Member

renefritze commented Jul 3, 2018

@sdrave look who's back and again not using the same config as in that other PR

@sdrave sdrave merged commit 87ccdb9 into master Jul 4, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sdrave sdrave deleted the to_numpy branch Jul 4, 2018

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Jul 4, 2018

@pmli, I would suggest that you merge sys-mor with master soonish s.t. these interface changes propagate to your branch ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment