Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conj method for vectorarrays #447

Merged
merged 2 commits into from Jul 3, 2018
Merged

Add conj method for vectorarrays #447

merged 2 commits into from Jul 3, 2018

Conversation

@pmli
Copy link
Member

@pmli pmli commented Jul 2, 2018

See #445.

@pmli pmli requested a review from sdrave Jul 2, 2018
Copy link
Member

@sdrave sdrave left a comment

We will also need a default impl in VectorArrayInterface which just returns self.copy().

src/pymor/vectorarrays/numpy.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Jul 2, 2018

Codecov Report

Merging #447 into master will decrease coverage by 0.03%.
The diff coverage is 41.66%.

Impacted Files Coverage Δ
src/pymor/vectorarrays/numpy.py 80.68% <25%> (-0.6%) ⬇️
src/pymor/vectorarrays/interfaces.py 79.39% <50%> (-1.11%) ⬇️
src/pymor/vectorarrays/block.py 90.41% <50%> (-0.57%) ⬇️
@pmli pmli force-pushed the va-conj branch from f8e7b9e to 9f46915 Jul 3, 2018
@pmli
Copy link
Member Author

@pmli pmli commented Jul 3, 2018

We will also need a default impl in VectorArrayInterface which just returns self.copy().

@sdrave Should there also be default implementations of real and imag?

@sdrave
Copy link
Member

@sdrave sdrave commented Jul 3, 2018

Would not hurt to have default implementations for real and imag. conj is more important though, since we want to use it in VectorArrayOperator.

@pmli
Copy link
Member Author

@pmli pmli commented Jul 3, 2018

Would not hurt to have default implementations for real and imag.

In this PR or a different one?

@sdrave
Copy link
Member

@sdrave sdrave commented Jul 3, 2018

As you prefer ..

@pmli
Copy link
Member Author

@pmli pmli commented Jul 3, 2018

Here it is.

@sdrave
sdrave approved these changes Jul 3, 2018
@pmli pmli merged commit c7dd1e5 into master Jul 3, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@pmli pmli deleted the va-conj branch Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants