Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conj method for vectorarrays #447

Merged
merged 2 commits into from Jul 3, 2018
Merged

Add conj method for vectorarrays #447

merged 2 commits into from Jul 3, 2018

Conversation

pmli
Copy link
Member

@pmli pmli commented Jul 2, 2018

See #445.

@pmli pmli requested a review from sdrave July 2, 2018 15:57
sdrave
sdrave reviewed Jul 2, 2018
View reviewed changes
Copy link
Member

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need a default impl in VectorArrayInterface which just returns self.copy().

src/pymor/vectorarrays/numpy.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 2, 2018 •
edited

Codecov Report

Merging #447 into master will decrease coverage by 0.03%.
The diff coverage is 41.66%.

Impacted Files Coverage Δ
src/pymor/vectorarrays/numpy.py 80.68% <25%> (-0.6%) ⬇️
src/pymor/vectorarrays/interfaces.py 79.39% <50%> (-1.11%) ⬇️
src/pymor/vectorarrays/block.py 90.41% <50%> (-0.57%) ⬇️

@renefritze renefritze mentioned this pull request Jul 3, 2018
Merged
@pmli
Copy link
Member Author

pmli commented Jul 3, 2018

We will also need a default impl in VectorArrayInterface which just returns self.copy().

@sdrave Should there also be default implementations of real and imag?

@sdrave
Copy link
Member

sdrave commented Jul 3, 2018

Would not hurt to have default implementations for real and imag. conj is more important though, since we want to use it in VectorArrayOperator.

@pmli
Copy link
Member Author

pmli commented Jul 3, 2018

Would not hurt to have default implementations for real and imag.

In this PR or a different one?

@sdrave
Copy link
Member

sdrave commented Jul 3, 2018

As you prefer ..

@pmli
Copy link
Member Author

pmli commented Jul 3, 2018

Here it is.

@pmli pmli merged commit c7dd1e5 into master Jul 3, 2018
@pmli pmli deleted the va-conj branch July 3, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrave sdrave sdrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmli @sdrave