New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to pymor.algorithms.ei.deim #452

Merged
merged 6 commits into from Jul 18, 2018

Conversation

Projects
None yet
1 participant
@sdrave
Copy link
Member

sdrave commented Jul 18, 2018

No description provided.

sdrave added some commits Jul 18, 2018

[ei] Some improvements to deim algorithm
* Error output is useless and removed.
* Thus, error_norm is no longer needed.
* Add inner product for pod computation.
* Return pod singular values in data dict.
* Add atol / rtol parameters.
* Add pod_options parameter for further pod params.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jul 18, 2018

Codecov Report

Merging #452 into master will increase coverage by 0.17%.
The diff coverage is 63.63%.

Impacted Files Coverage Δ
src/pymor/algorithms/ei.py 52.94% <63.63%> (+12%) ⬆️
src/pymor/operators/ei.py 59.34% <0%> (+0.81%) ⬆️

@sdrave sdrave merged commit 731dbf3 into master Jul 18, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sdrave sdrave deleted the improve_deim branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment