New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new complex proposal #459

Merged
merged 8 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@sdrave
Copy link
Member

sdrave commented Sep 4, 2018

This implements #458.

@sdrave sdrave force-pushed the new_complex branch from bec4000 to c77ce9b Sep 4, 2018

Show resolved Hide resolved src/pymor/operators/constructions.py Outdated
Show resolved Hide resolved src/pymor/operators/basic.py
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 5, 2018

Codecov Report

Merging #459 into master will decrease coverage by 0.07%.
The diff coverage is 77.08%.

Impacted Files Coverage Δ
src/pymor/reductors/parabolic.py 95.74% <ø> (ø) ⬆️
src/pymor/algorithms/image.py 77.45% <ø> (ø) ⬆️
src/pymor/algorithms/preassemble.py 78.57% <0%> (ø) ⬆️
src/pymor/algorithms/to_matrix.py 100% <100%> (ø) ⬆️
src/pymor/discretizers/disk.py 89.84% <100%> (ø) ⬆️
src/pymor/operators/cg.py 82.2% <100%> (ø) ⬆️
src/pymor/discretizers/fv.py 84% <100%> (ø) ⬆️
src/pymor/operators/fv.py 63.57% <100%> (ø) ⬆️
src/pymor/algorithms/genericsolvers.py 77.29% <100%> (ø) ⬆️
src/pymor/operators/interfaces.py 63.15% <100%> (-5.27%) ⬇️
... and 15 more
@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Sep 6, 2018

I guess we can merge this now, @pmli?

@pmli

This comment has been minimized.

Copy link
Member

pmli commented Sep 6, 2018

@sdrave What do you think about adding tests with complex data, maybe just changing some tests with real data to complex?

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Sep 6, 2018

You surely are right that having more tests for the complex case would be beneficial. However, I would like to get this off the table before my two-month leave. Also, the whole test suite should be revamped as part of the dfg project. How about merging now and adding an issue with 0.6 milestone regarding the tests?

@pmli

This comment has been minimized.

Copy link
Member

pmli commented Sep 6, 2018

Ok, that's fine. Go ahead with merging and then I'll work on merging this to sys-mor.

@sdrave sdrave merged commit 4fa1353 into master Sep 6, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pmli pmli deleted the new_complex branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment