Conversation
renefritze
approved these changes
Nov 21, 2018
Member
renefritze
left a comment
renefritze
left a comment
There was a problem hiding this comment.
Yeah, that's how I circumvented this issue in my branch too. I just didn't think it was a 'proper' fix. As in this issue might actually not be limited to solver_options.
Member
Author
|
What do you mean by 'not limited to solver_options'? |
Member
|
That it's possible other operator properties should also be excluded from being projected. |
Codecov Report
|
Member
Author
|
I don't think there are any other properties which might be affected .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467.