Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] ensure solver_options are removed from projected operators #481

Merged
merged 3 commits into from Nov 23, 2018

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 21, 2018

Fixes #467.

@sdrave sdrave requested a review from renefritze Nov 21, 2018
@sdrave sdrave added this to the 0.5 milestone Nov 21, 2018
Copy link
Member

@renefritze renefritze left a comment

Yeah, that's how I circumvented this issue in my branch too. I just didn't think it was a 'proper' fix. As in this issue might actually not be limited to solver_options.

@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 21, 2018

What do you mean by 'not limited to solver_options'?

@renefritze
Copy link
Member

@renefritze renefritze commented Nov 21, 2018

That it's possible other operator properties should also be excluded from being projected.

@codecov
Copy link

@codecov codecov bot commented Nov 23, 2018

Codecov Report

Merging #481 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted Files Coverage Δ
src/pymor/algorithms/projection.py 75.71% <60%> (+0.35%) ⬆️

@sdrave
Copy link
Member Author

@sdrave sdrave commented Nov 23, 2018

I don't think there are any other properties which might be affected ..

@sdrave sdrave merged commit feda9aa into master Nov 23, 2018
4 checks passed
@sdrave sdrave deleted the fix_467 branch Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants