New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project] ensure solver_options are removed from projected operators #481

Merged
merged 3 commits into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@sdrave
Copy link
Member

sdrave commented Nov 21, 2018

Fixes #467.

@sdrave sdrave requested a review from renefritze Nov 21, 2018

@sdrave sdrave added this to the 0.5 milestone Nov 21, 2018

@renefritze
Copy link
Member

renefritze left a comment

Yeah, that's how I circumvented this issue in my branch too. I just didn't think it was a 'proper' fix. As in this issue might actually not be limited to solver_options.

@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Nov 21, 2018

What do you mean by 'not limited to solver_options'?

@renefritze

This comment has been minimized.

Copy link
Member

renefritze commented Nov 21, 2018

That it's possible other operator properties should also be excluded from being projected.

@sdrave sdrave force-pushed the fix_467 branch from e8bb205 to e24bbc9 Nov 22, 2018

@sdrave sdrave force-pushed the fix_467 branch from e24bbc9 to a5e6de0 Nov 22, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #481 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted Files Coverage Δ
src/pymor/algorithms/projection.py 75.71% <60%> (+0.35%) ⬆️
@sdrave

This comment has been minimized.

Copy link
Member Author

sdrave commented Nov 23, 2018

I don't think there are any other properties which might be affected ..

@sdrave sdrave merged commit feda9aa into master Nov 23, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sdrave sdrave deleted the fix_467 branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment