Skip to content

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 21, 2018

Fixes #475.

@sdrave sdrave added this to the 0.5 milestone Nov 21, 2018
@sdrave
Copy link
Member Author

sdrave commented Nov 21, 2018

The results can be seen here.

@sdrave sdrave requested a review from pmli November 21, 2018 16:05
Copy link
Member

@pmli pmli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I especially like that most of the references are systems-theoretical 👌

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #484 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/pymor/algorithms/lyapunov.py 74.82% <ø> (ø) ⬆️
src/pymor/reductors/interpolation.py 76.63% <ø> (ø) ⬆️
src/pymor/reductors/parabolic.py 95.74% <ø> (ø) ⬆️
src/pymor/reductors/bt.py 53.9% <ø> (ø) ⬆️
src/pymor/reductors/sobt.py 81.43% <ø> (ø) ⬆️
src/pymor/reductors/coercive.py 76.92% <ø> (ø) ⬆️
src/pymor/reductors/sor_irka.py 65.68% <ø> (ø) ⬆️
src/pymor/algorithms/adaptivegreedy.py 83.62% <ø> (ø) ⬆️
src/pymor/reductors/h2.py 65.56% <ø> (ø) ⬆️
src/pymor/core/defaults.py 71.32% <0%> (-13.41%) ⬇️
... and 3 more

@sdrave sdrave merged commit 0f9e1ef into master Nov 22, 2018
@sdrave sdrave deleted the bibliography.bib branch November 22, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants