Skip to content

/ pymor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[operators.block] add BlockRowOperator, BlockColumnOperator #488

Merged
merged 2 commits into from Nov 26, 2018
Merged

[operators.block] add BlockRowOperator, BlockColumnOperator #488

merged 2 commits into from Nov 26, 2018

Conversation

@sdrave
Copy link
Member

@sdrave sdrave commented Nov 23, 2018

Fixes #485. Should also simplify the situation for #478.
@sdrave sdrave requested a review from pmli Nov 23, 2018
@pmli
pmli approved these changes Nov 23, 2018
View changes
Copy link
Member

@pmli pmli left a comment

Looks great, I just have some nitpicks.
src/pymor/operators/block.py Outdated Show resolved Hide resolved
src/pymor/operators/block.py Outdated Show resolved Hide resolved
@sdrave
[operators.block] add BlockRowOperator, BlockColumnOperator
Loading status checks…
3ee4de7 
as well as BlockProjectionOperator and BlockEmbeddingOperator.
hstack and vstack seem no longer useful and are removed
@sdrave sdrave force-pushed the block_rowcolumn_operator branch from 1e9eb67 to 3ee4de7 Nov 23, 2018
@codecov
Copy link

@codecov codecov bot commented Nov 23, 2018 •
edited

Codecov Report

Merging #488 into master will decrease coverage by 0.1%.
The diff coverage is 79.36%.

Impacted Files Coverage Δ
src/pymor/reductors/sor_irka.py 66.32% <ø> (+0.64%) ⬆️
src/pymor/algorithms/to_matrix.py 100% <100%> (ø) ⬆️
src/pymor/discretizations/iosys.py 63.9% <66.66%> (-0.52%) ⬇️
src/pymor/operators/block.py 65.51% <80.76%> (-0.53%) ⬇️
src/pymor/operators/constructions.py 82.7% <0%> (-1.49%) ⬇️
src/pymor/vectorarrays/block.py 91.78% <0%> (-0.69%) ⬇️
@sdrave
[tests] add fixtures for BlockRowOperator and BlockColumnOperator
Loading status checks…
408f985
@sdrave sdrave merged commit 1aeccb4 into master Nov 26, 2018
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@sdrave sdrave deleted the block_rowcolumn_operator branch Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sdrave @pmli