Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[operators.block] add BlockRowOperator, BlockColumnOperator #488
Conversation
sdrave
requested a review
from
pmli
Nov 23, 2018
pmli
approved these changes
Nov 23, 2018
Looks great, I just have some nitpicks. |
src/pymor/operators/block.py Outdated
src/pymor/operators/block.py Outdated
sdrave
force-pushed the
block_rowcolumn_operator
branch
from
1e9eb67
to
3ee4de7
Nov 23, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 23, 2018
•
Codecov Report
|
sdrave
merged commit 1aeccb4
into
master
Nov 26, 2018
sdrave
deleted the
block_rowcolumn_operator
branch
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sdrave commentedNov 23, 2018
Fixes #485. Should also simplify the situation for #478.