Skip to content

Output functionals in CG discretizations#489

Merged
sdrave merged 4 commits into
masterfrom
discretize_output_functionals
Dec 3, 2018
Merged

Output functionals in CG discretizations#489
sdrave merged 4 commits into
masterfrom
discretize_output_functionals

Conversation

@sdrave
Copy link
Copy Markdown
Member

@sdrave sdrave commented Nov 26, 2018

This PR adds support for assembling arbitrary l2 output functionals (on the interior or the boundary) for cg discretizations:

  • InstationaryProblem gets an additional functionals attribute to specify output functionals.
  • Assembly of these functionals is only implemented for CG. FV is still missing.
  • In pymor.operators.cg, the boundary treatment is moved to BoundaryL2ProductFunctionalP/Q1 which handles the assembly of dirichlet / neumann or arbitrary boundary l2 functionals. BoundaryDirichletFunctional is used for enforcing dirichlet constraints.

Additionally:

  • A small fix for NumpyMatrixBasedOperator.H.
  • Functions can now be multiplied, yielding a ProductFunction.

@sdrave
Copy link
Copy Markdown
Member Author

sdrave commented Nov 26, 2018

FYI, I want this in 0.5 as a preparation for #454, #469.

@sdrave sdrave added this to the 0.5 milestone Nov 26, 2018
@sdrave sdrave requested a review from ftalbrecht November 26, 2018 15:58
@sdrave sdrave force-pushed the discretize_output_functionals branch from d3823e4 to 38c8c0e Compare November 26, 2018 19:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 26, 2018

Codecov Report

Merging #489 into master will increase coverage by 0.35%.
The diff coverage is 84.35%.

Impacted Files Coverage Δ
src/pymor/operators/numpy.py 80.9% <0%> (ø) ⬆️
src/pymor/analyticalproblems/elliptic.py 100% <100%> (ø) ⬆️
src/pymor/functions/basic.py 87.39% <26.31%> (-11.63%) ⬇️
src/pymor/discretizers/fv.py 83.46% <50%> (-0.54%) ⬇️
src/pymor/discretizers/cg.py 86.06% <76.47%> (-2.01%) ⬇️
src/pymor/grids/interfaces.py 82.3% <85.71%> (-0.31%) ⬇️
src/pymor/operators/cg.py 87.64% <97.95%> (+5.43%) ⬆️
src/pymor/vectorarrays/block.py 92.46% <0%> (+0.68%) ⬆️
src/pymor/operators/constructions.py 84.18% <0%> (+1.48%) ⬆️
... and 3 more

@sdrave sdrave force-pushed the discretize_output_functionals branch from 38c8c0e to a1a2468 Compare November 27, 2018 12:09
@sdrave sdrave merged commit 4b6a193 into master Dec 3, 2018
@sdrave sdrave deleted the discretize_output_functionals branch December 3, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant