You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #550, this PR renames Discretizations to Models. What is still missing is the renaming of the variables. I would suggest:
d -> m for a generic model
d -> fom for the full order model
d -> rom for the reduced model
I agree.
Then, not to have confusion about m, maybe InputOutputModel.m should be renamed, and then also p and InputStateOutputModel.n (n/m/p are not really standard names anyhow). How about input_dim, output_dim and state_dim? Or order instead of state_dim?
@pmli, assuming all lights turn green, I am finished with the conversion. Shall we change the mentioned attribute in a different PR, or do you want to push the changes into this branch?
sdrave
changed the title
[WIP] Rename Discretizations to Models
Rename Discretizations to Models
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #550, this PR renames
DiscretizationstoModels. What is still missing is the renaming of the variables. I would suggest:d -> m for a generic model
d -> fom for the full order model
d -> rom for the reduced model
Alternatively, we could always use
mfor the full order model.