-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Discretizations to Models #568
Conversation
Codecov Report
|
Codecov Report
|
I agree. |
Ok, will go ahead with changing the variable names .. |
@pmli, assuming all lights turn green, I am finished with the conversion. Shall we change the mentioned attribute in a different PR, or do you want to push the changes into this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot going on in this PR, so maybe it's better to do other changes in a different one.
As discussed in #550, this PR renames
Discretizations
toModels
. What is still missing is the renaming of the variables. I would suggest:d -> m for a generic model
d -> fom for the full order model
d -> rom for the reduced model
Alternatively, we could always use
m
for the full order model.