Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Discretizations to Models #568

Merged
merged 9 commits into from Feb 1, 2019
Merged

Rename Discretizations to Models #568

merged 9 commits into from Feb 1, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 31, 2019

As discussed in #550, this PR renames Discretizations to Models. What is still missing is the renaming of the variables. I would suggest:

d -> m for a generic model
d -> fom for the full order model
d -> rom for the reduced model

Alternatively, we could always use m for the full order model.

@sdrave sdrave requested a review from pmli Jan 31, 2019
@sdrave sdrave added pr:change interfaces labels Jan 31, 2019
@sdrave sdrave added this to the 2019.2 milestone Jan 31, 2019
@codecov
Copy link

@codecov codecov bot commented Jan 31, 2019

Codecov Report

Merging #568 into master will decrease coverage by 37.22%.
The diff coverage is 52%.

Impacted Files Coverage Δ
src/pymor/algorithms/greedy.py 10.66% <ø> (-74.67%) ⬇️
src/pymor/reductors/coercive.py 16.15% <ø> (-60.77%) ⬇️
src/pymor/algorithms/timestepping.py 13.39% <ø> (-64.29%) ⬇️
src/pymor/vectorarrays/interfaces.py 69.59% <ø> (-8.78%) ⬇️
src/pymor/vectorarrays/mpi.py 32.27% <ø> (ø) ⬆️
src/pymor/algorithms/adaptivegreedy.py 8.36% <ø> (-75.27%) ⬇️
src/pymor/parameters/base.py 54.54% <ø> (-17.12%) ⬇️
src/pymor/reductors/parabolic.py 27.65% <ø> (-68.09%) ⬇️
src/pymor/gui/visualizers.py 53.33% <ø> (-31.12%) ⬇️
src/pymor/algorithms/ei.py 9.31% <ø> (-43.63%) ⬇️
... and 112 more

@codecov
Copy link

@codecov codecov bot commented Jan 31, 2019

Codecov Report

Merging #568 into master will increase coverage by 0.05%.
The diff coverage is 75.39%.

Impacted Files Coverage Δ
src/pymor/algorithms/timestepping.py 77.67% <ø> (ø) ⬆️
src/pymor/vectorarrays/interfaces.py 78.36% <ø> (ø) ⬆️
src/pymor/vectorarrays/mpi.py 32.27% <ø> (ø) ⬆️
src/pymor/parameters/base.py 71.65% <ø> (ø) ⬆️
src/pymor/basic.py 100% <100%> (ø) ⬆️
src/pymor/discretizers/disk.py 89.84% <100%> (ø) ⬆️
src/pymor/models/interfaces.py 83.33% <100%> (ø)
src/pymor/operators/block.py 68.58% <100%> (ø) ⬆️
src/pymor/models/iosys.py 61.48% <100%> (ø)
src/pymor/reductors/parabolic.py 95.74% <100%> (ø) ⬆️
... and 21 more

@pmli
Copy link
Member

@pmli pmli commented Jan 31, 2019

As discussed in #550, this PR renames Discretizations to Models. What is still missing is the renaming of the variables. I would suggest:

d -> m for a generic model
d -> fom for the full order model
d -> rom for the reduced model

I agree.
Then, not to have confusion about m, maybe InputOutputModel.m should be renamed, and then also p and InputStateOutputModel.n (n/m/p are not really standard names anyhow). How about input_dim, output_dim and state_dim? Or order instead of state_dim?

@sdrave
Copy link
Member Author

@sdrave sdrave commented Jan 31, 2019

Ok, will go ahead with changing the variable names ..

@sdrave
Copy link
Member Author

@sdrave sdrave commented Feb 1, 2019

@pmli, assuming all lights turn green, I am finished with the conversion. Shall we change the mentioned attribute in a different PR, or do you want to push the changes into this branch?

pmli
pmli approved these changes Feb 1, 2019
Copy link
Member

@pmli pmli left a comment

There is a lot going on in this PR, so maybe it's better to do other changes in a different one.

@sdrave sdrave merged commit cf4782d into master Feb 1, 2019
4 checks passed
@sdrave sdrave deleted the disc_to_model branch Feb 1, 2019
@sdrave sdrave changed the title [WIP] Rename Discretizations to Models Rename Discretizations to Models Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants