Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NonProjectedResidualOperator.apply #569

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Fix NonProjectedResidualOperator.apply #569

merged 3 commits into from
Jan 31, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jan 31, 2019

This fixes residual computation in NonProjectedResidualOperator as in #566.
Addresses #555.

@sdrave sdrave added pr:fix Fixes a bug rb labels Jan 31, 2019
@sdrave sdrave added this to the 2019.2 milestone Jan 31, 2019
@sdrave sdrave force-pushed the fix_residual_current branch from f73684a to c75eaea Compare January 31, 2019 14:48
@sdrave
Copy link
Member Author

sdrave commented Jan 31, 2019

@andreasbuhr, please take a look ..

@andreasbuhr
Copy link
Contributor

looks good to me

@sdrave sdrave added the backport Should be ported back to current release label Jan 31, 2019
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #569 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted Files Coverage Δ
src/pymor/reductors/residual.py 66.23% <0%> (-4.12%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #569 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted Files Coverage Δ
src/pymor/reductors/residual.py 66.23% <0%> (-4.12%) ⬇️

@sdrave sdrave merged commit bce9667 into master Jan 31, 2019
@sdrave sdrave deleted the fix_residual_current branch January 31, 2019 19:36
@sdrave sdrave mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Should be ported back to current release pr:fix Fixes a bug
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrave @andreasbuhr