Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename system attributes n, m, p #578

merged 1 commit into from Feb 2, 2019

Rename system attributes n, m, p #578

merged 1 commit into from Feb 2, 2019


Copy link

@pmli pmli commented Feb 1, 2019

Renaming is as follows:

  • n -> order
  • m -> input_dim
  • p -> output_dim

Other suggestions are welcome. order is used in places related to quadrature. Maybe shortening input_dim and output_dim would be good, e.g., in_dim and out_dim. Or replacing input_dim and output_dim with an attribute shape = (m.output_space.dim, m.input_space.dim).

@pmli pmli added sys-mor pr:change labels Feb 1, 2019
@pmli pmli added this to the 2019.2 milestone Feb 1, 2019
@pmli pmli requested a review from sdrave Feb 1, 2019
Copy link

@codecov codecov bot commented Feb 1, 2019

Codecov Report

Merging #578 into master will increase coverage by <.01%.
The diff coverage is 52%.

Impacted Files Coverage Δ
src/pymor/reductors/ 81.32% <100%> (ø) ⬆️
src/pymor/reductors/ 63.91% <12.5%> (-0.67%) ⬇️
src/pymor/reductors/ 64.87% <46.66%> (ø) ⬆️
src/pymor/models/ 61.48% <50%> (ø) ⬆️
src/pymor/reductors/ 65.3% <66.66%> (ø) ⬆️
src/pymor/reductors/ 79.51% <83.33%> (ø) ⬆️
src/pymor/gui/ 22.74% <0%> (+0.36%) ⬆️

sdrave approved these changes Feb 2, 2019
Copy link

@sdrave sdrave left a comment

I like the new names!

@pmli pmli merged commit 39dded5 into master Feb 2, 2019
4 checks passed
@pmli pmli deleted the sys-attributes branch Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants