Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[models.iosys] remove space id handling except for factory methods #611

Merged
merged 1 commit into from Mar 1, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Mar 1, 2019

As suggested in #609, I have removed most VectorSpace id code from models.iosys. What remains is the ability to assign space ids when loading matrices from disk.

@sdrave sdrave added sys-mor pr:removal labels Mar 1, 2019
@sdrave sdrave added this to the 2019.2 milestone Mar 1, 2019
@sdrave sdrave requested a review from pmli Mar 1, 2019
pmli
pmli approved these changes Mar 1, 2019
@sdrave sdrave merged commit e1f2b51 into master Mar 1, 2019
7 checks passed
@sdrave sdrave deleted the iosys_remove_id branch Mar 1, 2019
sdrave added a commit that referenced this issue Mar 1, 2019
[models.iosys] remove space id handling except for factory methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants