Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VectorArrayInterface.ones and VectorArrayInterface.full #612

Merged
merged 6 commits into from Mar 6, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Mar 1, 2019

As discussed in #544.

Note that I decided to let value be the first argument in full since count is an optional argument in zeros, ones and empty. Unfortunately, it's the other way around for numpy.full. However, I believe it is still better to keep the interface in pyMOR consistent.

@sdrave sdrave added pr:new-feature interfaces labels Mar 1, 2019
@sdrave sdrave added this to the 2019.2 milestone Mar 1, 2019
@sdrave sdrave requested a review from pmli Mar 1, 2019
pmli
pmli approved these changes Mar 1, 2019
@sdrave sdrave merged commit 2f9af6d into master Mar 6, 2019
7 checks passed
@sdrave sdrave deleted the va_full branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants