Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from BlockVectorSpace #614

Merged
merged 1 commit into from Mar 6, 2019
Merged

Remove id from BlockVectorSpace #614

merged 1 commit into from Mar 6, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Mar 6, 2019

This removes the feature to specify a id for BlockVectorSpaces. The rationale is that we no longer need ids for the reduction process and a BlockVectorSpace should usually be uniquely determined by the ids of its subspaces.

See #609.

@sdrave sdrave added pr:removal generic-objects labels Mar 6, 2019
@sdrave sdrave added this to the 2019.2 milestone Mar 6, 2019
@sdrave sdrave requested a review from pmli Mar 6, 2019
pmli
pmli approved these changes Mar 6, 2019
@sdrave sdrave merged commit 4aef564 into master Mar 6, 2019
7 checks passed
@sdrave sdrave deleted the blockop_remove_id branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants