Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'space' parameter from as_vector #615

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Mar 6, 2019

By requiring that VectorArrays representing the real/complex numbers should have no space id, the space parameter from OperatorInterface.as_vector becomes obsolete. This also means that there is one and only one VectorSpace representing real/complex numbers, namely NumpyVectorSpace(1).

See #609.

@sdrave sdrave added pr:change pr:removal interfaces labels Mar 6, 2019
@sdrave sdrave added this to the 2019.2 milestone Mar 6, 2019
@sdrave sdrave requested a review from pmli Mar 6, 2019
pmli
pmli approved these changes Mar 6, 2019
@sdrave sdrave merged commit 9ad226a into master Mar 6, 2019
7 checks passed
@sdrave sdrave deleted the as_vector_remove_id branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change pr:removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants