Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-mor API changes #656

Merged
merged 3 commits into from Mar 23, 2019
Merged

sys-mor API changes #656

merged 3 commits into from Mar 23, 2019

Conversation

pmli
Copy link
Member

@pmli pmli commented Mar 22, 2019

Some changes to API which should improve things:

  • turn some methods in reductors.bt private, to show that only reduce and error_bounds should be used
  • remove hsU and hsV methods from LTIModel since hsv is far more useful and it could be confused with hsV
  • give gamma in BRBTReductor a default value 1, because "bounded real" means "H_inf-norm bounded by 1" in standard terminology

@pmli pmli added sys-mor pr:change Change in existing functionality labels Mar 22, 2019
@pmli pmli added this to the 2019.2 milestone Mar 22, 2019
@pmli pmli requested a review from sdrave Mar 22, 2019
sdrave
sdrave approved these changes Mar 22, 2019
View changes
@pmli pmli merged commit b040eb1 into master Mar 23, 2019
@pmli pmli deleted the iosys-api-changes branch Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrave sdrave

Assignees
No one assigned
Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmli @sdrave