Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sys-mor] various reductor improvements #661

Merged
merged 7 commits into from Mar 27, 2019
Merged

[sys-mor] various reductor improvements #661

merged 7 commits into from Mar 27, 2019

Conversation

pmli
Copy link
Member

@pmli pmli commented Mar 25, 2019

  • removes reduce_arnoldi from LTI_BHIReductor, merges use_arnoldi option with projection
  • initializes reductor attributes in __init__
  • makes pg_redutor a private attribute
  • sets reduced D operator in SOBTReductor
  • renames TFInterpReductor to TF_BHIReductor to fit with other "BHI" reductors
  • docs and other minor improvements

pmli added 5 commits Mar 25, 2019
- initialize all class attributes in __init__
- merge use_arnoldi into projection
- add reductors to non-projection-based methods
- various minor improvements
@pmli pmli added sys-mor pr:change labels Mar 25, 2019
@pmli pmli added this to the 2019.2 milestone Mar 25, 2019
@pmli pmli self-assigned this Mar 25, 2019
@pmli pmli requested a review from sdrave Mar 26, 2019
Copy link
Member

@sdrave sdrave left a comment

LGTM. However, I would prefer TFBHIReductor. TF_BHIReductor looks awkward (does PEP8 allow it?)

@pmli
Copy link
Member Author

@pmli pmli commented Mar 27, 2019

However, I would prefer TFBHIReductor. TF_BHIReductor looks awkward (does PEP8 allow it?)

I agree. (flake8 does not complain.) I'll remove the underscore also from other "BHI" and "IRKA" methods.

sdrave
sdrave approved these changes Mar 27, 2019
@pmli pmli merged commit 7959e30 into master Mar 27, 2019
7 checks passed
@pmli pmli deleted the fix-sys-mor-reductors branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants