Skip to content

[sys-mor] various reductor improvements #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 27, 2019
Merged

[sys-mor] various reductor improvements #661

merged 7 commits into from
Mar 27, 2019

Conversation

pmli
Copy link
Member

@pmli pmli commented Mar 25, 2019 •
edited
Loading

  • removes reduce_arnoldi from LTI_BHIReductor, merges use_arnoldi option with projection
  • initializes reductor attributes in __init__
  • makes pg_redutor a private attribute
  • sets reduced D operator in SOBTReductor
  • renames TFInterpReductor to TF_BHIReductor to fit with other "BHI" reductors
  • docs and other minor improvements

pmli added 5 commits March 25, 2019 20:13
@pmli
[reductors] sys-mor docs improvements
8a6e976
@pmli
[reductors.h2] remove unnecessary np.random.seed
32111ef
@pmli
[reductors] sys-mor improvements
2d50175 
- initialize all class attributes in __init__
- merge use_arnoldi into projection
- add reductors to non-projection-based methods
- various minor improvements
@pmli
[demos] update
c532927
@pmli
[notebooks] update
c710ff2
@pmli pmli added sys-mor pr:change Change in existing functionality labels Mar 25, 2019
@pmli pmli added this to the 2019.2 milestone Mar 25, 2019
@pmli pmli self-assigned this Mar 25, 2019
@pmli pmli requested a review from sdrave March 26, 2019 12:46
sdrave
sdrave reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I would prefer TFBHIReductor. TF_BHIReductor looks awkward (does PEP8 allow it?)

@pmli
Copy link
Member Author

pmli commented Mar 27, 2019

However, I would prefer TFBHIReductor. TF_BHIReductor looks awkward (does PEP8 allow it?)

I agree. (flake8 does not complain.) I'll remove the underscore also from other "BHI" and "IRKA" methods.

@pmli pmli merged commit 7959e30 into master Mar 27, 2019
@pmli pmli deleted the fix-sys-mor-reductors branch March 27, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdrave sdrave sdrave approved these changes

Assignees

@pmli pmli

Labels
pr:change Change in existing functionality
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@pmli @sdrave