Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed complex norms #668

Merged
merged 1 commit into from Apr 17, 2019
Merged

Fixed complex norms #668

merged 1 commit into from Apr 17, 2019

Conversation

deneick
Copy link
Contributor

@deneick deneick commented Apr 8, 2019

This addresses #667.

@pmli pmli added interfaces pr:fix labels Apr 8, 2019
@pmli pmli added this to the 2019.2 milestone Apr 8, 2019
@pmli
Copy link
Member

@pmli pmli commented Apr 8, 2019

Could you also add yourself in AUTHORS.md under pyMOR 2019.2?

@deneick
Copy link
Contributor Author

@deneick deneick commented Apr 9, 2019

@pmli Yes, I did in #665.

src/pymor/vectorarrays/interfaces.py Outdated Show resolved Hide resolved
src/pymor/vectorarrays/interfaces.py Outdated Show resolved Hide resolved
@deneick deneick force-pushed the complexnorm branch 2 times, most recently from 84e776c to 92df5cf Compare Apr 16, 2019
pmli
pmli approved these changes Apr 16, 2019
Copy link
Member

@pmli pmli left a comment

LGTM
@sdrave Thoughts?

@sdrave
Copy link
Member

@sdrave sdrave commented Apr 16, 2019

LGTM as well. @deneick, I think this should also be mentioned in AUTHORS.md. Can you make a short entry?

@pmli pmli merged commit a9e8fed into pymor:master Apr 17, 2019
4 of 7 checks passed
@pmli
Copy link
Member

@pmli pmli commented Apr 17, 2019

Thanks again @deneick.

deneick pushed a commit to deneick/pymor that referenced this issue Apr 17, 2019
Fixed complex norms

upgrade to master

remove warnings

gram schmidt warning removed

gitignore fix

gitignorefix

gitignorefix

unglkfull fix

unglkfull fix

unglkfull fix

unglkfull fix

m-patches + helmholtz_contrast

m-patches stuff

m-patches stuff

randrangefinder + powerits

poweritevamp

poweritmpfix

rrf gram_schmidt added

added extend to rrf

added extend to rrf2

testm+

dels

rand

[algorithms.randrangefinder] added randomized algorithms

[vectorarrays.interfaces] complex fix in norm/norm2

lmor

del MA

ipynb

[lmor]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants