Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'linear' attribute to StationaryModel and InstationaryModel #702

merged 4 commits into from Jun 5, 2019


Copy link

@pmli pmli commented Jun 4, 2019

(Part of the changes from #652)

Since rhs and mass are asserted to be linear, it should be enough to add self.linear = operator.linear.

@pmli pmli added pr:new-feature Introduces a new feature builtin-models labels Jun 4, 2019
@pmli pmli added this to the 2019.2 milestone Jun 4, 2019
@pmli pmli requested a review from sdrave June 4, 2019 18:53
Copy link

@sdrave sdrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the outputs dict. Is a Model linear when Operator is linear but one of the outputs Operators is nonlinear? I am not completely sure what the right definition would be, but I would tend to require the outputs to be linear as well.

Copy link
Member Author

pmli commented Jun 5, 2019

Right, for the input-output system to be linear, the output should also be linear (although a linear input-output system with a nonlinear operator and output could be constructed...).

src/pymor/models/ Outdated Show resolved Hide resolved
src/pymor/models/ Outdated Show resolved Hide resolved
@pmli pmli merged commit 238d739 into master Jun 5, 2019
@pmli pmli deleted the model-basic-linear branch June 5, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
pr:new-feature Introduces a new feature
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants