Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 643 #716

Merged
merged 4 commits into from
Jul 1, 2019
Merged

Fix 643 #716

merged 4 commits into from
Jul 1, 2019

Conversation

sdrave
Copy link
Member

@sdrave sdrave commented Jun 19, 2019

This addresses #643. Should this be backported or are we already near enough to the next release?

@sdrave sdrave added this to the 2019.2 milestone Jun 19, 2019
@sdrave sdrave requested a review from pmli June 19, 2019 09:02
pmli
pmli approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@pmli pmli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebooks seem to have stayed the same.

I would be for backporting it. I'm not sure if we are near enough the next release or what "near enough" means.

@sdrave
[ConjugateParameterFunctional] use np.conj() instead of value.conj()
6bf85f8 
for cases where the functional fails to return a NumPy array
@sdrave sdrave mentioned this pull request Jul 1, 2019
Merged
@sdrave sdrave merged commit 34b35bd into master Jul 1, 2019
@sdrave sdrave deleted the fix_643 branch July 1, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmli pmli pmli approved these changes

Assignees
No one assigned
Labels
pr:fix Fixes a bug
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sdrave @pmli