Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on return values of
bode
,freqresp
,scipy.signal.bode
,scipy.signal.freqresp
,and
a better name for
pymor.models.iosys.InputOutputModel.bode
would befreqresp
(python-control'sfreqresp
is a bit different and behaves more likebode
in Matlab and SciPy). Since underscores are common inpymor.models.iosys
method names, I findfreq_resp
would be even better.Additionally, this PR replaces "Bode plot" with "magnitude plot". I'm not sure if "magnitude plot" is a name for something or if there is a standard name for the plot of
||H(i omega)||
vsomega
, but it seems that "Bode plot" and "Bode magnitude plot" refer to a grid of subplots with a column for each input and row for each output.I would still prefer to have
pymor.iosys.models.InputOutputModel.mag_plot
, since it's commonly used to visualize the MOR error.@sdrave Thoughts?